collectd/docs/maintainer_guide.md

Maintainer Guide

This document documents best practises and guidelines for collectd maintainers.

Ideology

As maintainer of an open-source project, you are one of the most knowledgable people of the project's structure, best practices, goals, etc. You are most helping the project by facilitating change, in other words "help contributors make changes to the codebase."

The most common form of helping users is doing code reviews and (eventually) using your commit rights to merge the pull request.

Code reviews

• Be friendly, especially with new contributors. Write "Hi" and thank them for their contribution before diving into review comments.
• Criticize code, not people. Ideally, tell the contributor a better way to do what they need.
• Clearly mark optional suggestions as such. Best practise, start your comment with At your option: …
• Wait for a successful run of our continuous integration system before merging.

Repository access

You have write access to the collectd/collectd repository. Please use it responsibly.