source/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-09 02:59:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

doc: Explain that low-effort pull requests may be closed

Browse Source
This commit is contained in:
MarcoFalke
2026-01-23 13:10:07 +01:00
parent 1b079becf1
commit fa15a8d2d0
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
CONTRIBUTING.md
View File

@@ -78,6 +78,13 @@ The codebase is maintained using the "contributor workflow" where everyone
without exception contributes patch proposals using "pull requests" (PRs). This without exception contributes patch proposals using "pull requests" (PRs). This
facilitates social contribution, easy testing and peer review. facilitates social contribution, easy testing and peer review.
Pull request authors must fully and confidently understand their own changes
and must have tested them. Contributors should mention which tests cover their
changes, or include the manual steps they used to confirm the change.
Contributors are expected to be prepared to clearly motivate and explain their
changes. If there is doubt, the pull request may be closed.
Please refer to the [peer review](#peer-review) section below for more details.
To contribute a patch, the workflow is as follows: To contribute a patch, the workflow is as follows:
1. Fork repository ([only for the first time](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo)) 1. Fork repository ([only for the first time](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo))
@@ -338,6 +345,11 @@ reviewers that the changes warrant the review effort, and if reviewers are
"Concept NACK'ing" the PR, the author may need to present arguments and/or do "Concept NACK'ing" the PR, the author may need to present arguments and/or do
research backing their suggested changes. research backing their suggested changes.
Moreover, if there is reasonable doubt that the pull request author does not
fully understand the changes they are submitting themselves, or if it becomes
clear that they have not tested the changes on a basic level themselves, the
pull request may be closed immediately.
#### Conceptual Review #### Conceptual Review
A review can be a conceptual review, where the reviewer leaves a comment A review can be a conceptual review, where the reviewer leaves a comment