mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-09 02:59:31 +08:00
fa2959e16dtest: Fail on self-check warnings in test_runner.py (MarcoFalke) Pull request description: I don't see a reason to start running the tests, if the test_runner detects warnings during the self-check. Usually, this will just lead to a possibly confusing test failure after some wasted time anyway. So just fail fast before even running any tests. If there was a reason to ignore the warnings, a new option could trivially be added: ```py parser.add_argument("--ignore-self-check-warnings", dest="ignore_warnings", default=False, action="store_true", help="Ignore test runner warnings about self-checks before running the tests") ``` However, I don't see the need. ACKs for top commit: hodlinator: utACKfa2959e16dTree-SHA512: 3f2e1af9ba06cd805c69e8c40149214a8a13af286ba6315c346e23d0f1ddae8e850103b6967d2d9799a095f6a8ec8802c3c773af8d7123598e8887f56c764fb5