source/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-09 02:59:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Separate peer/maybe_peer in ProcessMessages and SendMessages

Browse Source 
Introducing two names to refer to the peer makes it possible to have one
refer to a non-null reference in a later commit.
This commit is contained in:
MarcoFalke
2025-12-15 17:16:16 +01:00
parent fac529188e
commit fac5415466
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/net_processing.cpp
View File

@@ -5186,8 +5186,9 @@ bool PeerManagerImpl::ProcessMessages(CNode& node, std::atomic<bool>& interruptM
AssertLockHeld(g_msgproc_mutex);
CNode* pfrom{&node}; // alias removed in a later commit.
PeerRef peer = GetPeerRef(pfrom->GetId());
if (peer == nullptr) return false;
PeerRef maybe_peer{GetPeerRef(pfrom->GetId())};
if (maybe_peer == nullptr) return false;
auto& peer{maybe_peer}; // alias cleaned up in later commit.
// For outbound connections, ensure that the initial VERSION message
// has been sent first before processing any incoming messages
@@ -5689,8 +5690,9 @@ bool PeerManagerImpl::SendMessages(CNode& node)
AssertLockHeld(g_msgproc_mutex);
CNode* pto{&node}; // alias removed in a later commit
PeerRef peer = GetPeerRef(pto->GetId());
if (!peer) return false;
PeerRef maybe_peer{GetPeerRef(pto->GetId())};
if (!maybe_peer) return false;
auto& peer{maybe_peer}; // alias cleaned up in later commit
const Consensus::Params& consensusParams = m_chainparams.GetConsensus();
// We must call MaybeDiscourageAndDisconnect first, to ensure that we'll