53ccb75f0c
cd95c9d6a7subprocess: check and handle fcntl(F_GETFD) failure (Tomás Andróil)b7288decdfsubprocess: Proper implementation of wait() on Windows (Haowen Liu)7423214d8dsubprocess: Do not escape double quotes for command line arguments on Windows (Hennadii Stepanov)bb9ffea53fsubprocess: Explicitly define move constructor of Streams class (Shunsuke Shimizu)174bd43f2esubprocess: Avoid leaking POSIX name aliases beyond `subprocess.h` (Hennadii Stepanov)7997b7656fsubprocess: Fix cross-compiling with mingw toolchain (Hennadii Stepanov)647630462fsubprocess: Get Windows return code in wait() (Haowen Liu)d3f511b458subprocess: Fix string_arg when used with rref (Haowen Liu)2fd3f2fec6subprocess: Fix memory leaks (Haoran Peng) Pull request description: Most of these changes were developed during work on https://github.com/bitcoin/bitcoin/pull/29868 and https://github.com/bitcoin/bitcoin/pull/32342 and have since been upstreamed. As they are now merged, this PR backports them to our `src/util/subprocess.h` header. Required for https://github.com/bitcoin/bitcoin/pull/29868. A list of the backported PRs: - https://github.com/arun11299/cpp-subprocess/pull/106 - https://github.com/arun11299/cpp-subprocess/pull/110 - https://github.com/arun11299/cpp-subprocess/pull/109 - https://github.com/arun11299/cpp-subprocess/pull/99 - https://github.com/arun11299/cpp-subprocess/pull/112 - https://github.com/arun11299/cpp-subprocess/pull/107 - https://github.com/arun11299/cpp-subprocess/pull/113 - https://github.com/arun11299/cpp-subprocess/pull/116 - https://github.com/arun11299/cpp-subprocess/pull/117 The following PRs were skipped for backporting: - https://github.com/arun11299/cpp-subprocess/pull/108 because we are not planning to support this feature. - https://github.com/arun11299/cpp-subprocess/pull/101 because that change has been already landed in https://github.com/bitcoin/bitcoin/pull/29849. ACKs for top commit: theStack: Light ACKcd95c9d6a7laanwj: Code review re-ACKcd95c9d6a7Tree-SHA512: f9b60b932957d2e1cad1d87f2ad8bb68c97136e9735eb78547018a42cc50c4652750367f29462eadb0512c27db1dd8a7d4b17a2f0aeab62b3dbf86db5f51a61c
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.